Pdr/addressing review comments #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added clarification on session hijacking and session fixation. This resolves oauth-wg#82
Added an initial explanation to clarify the type of application within scope. This resolves oauth-wg#78
Clarified that we only focus on OAuth and not on other consequences (which are more broad and apply to all types of JS applications, regardless of OAuth). Hope this suffices, especially because the attack scenarios are clearly marked as non-exhaustive. The consequences are pretty well-defined and scoped, so I think this should work.
Added a section on the risks in the proxy component This resolves oauth-wg#81
This addresses the CSP comment of oauth-wg#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing review comments and improvements